Skip to content

Conversation

@maraf
Copy link
Member

@maraf maraf commented Jun 16, 2025

@maraf maraf added this to the 10.0.0 milestone Jun 16, 2025
@maraf maraf requested a review from ilonatommy June 16, 2025 12:42
@maraf maraf self-assigned this Jun 16, 2025
@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 12:42
@maraf maraf requested review from lewing and pavelsavara as code owners June 16, 2025 12:42
@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jun 16, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports a change to the Wasm SDK DevServer and adds a fingerprinting mechanism for user JavaScript files in the browser template. Key changes include:

  • Adding a StaticWebAssetFingerprintPattern for "*.js" files in the browser template.
  • Updating the DevServer’s WebAssemblyNetDebugProxyAppBuilderExtensions to normalize the DevTools frontend URL via a local function.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/mono/wasm/templates/templates/browser/browser.0.csproj Added fingerprinting configuration for JavaScript files to support asset caching.
src/mono/wasm/host/DevServer/WebAssemblyNetDebugProxyAppBuilderExtensions.cs Refactored DevTools URL construction to handle absolute and relative URLs by normalizing them.
Comments suppressed due to low confidence (1)

src/mono/wasm/host/DevServer/WebAssemblyNetDebugProxyAppBuilderExtensions.cs:455

  • Ensure that the variable 'query' extracted via UriHelper.FromAbsolute includes the proper leading '?' when concatenated. If it does not, consider adding the '?' prefix to form a valid URL.
return "${DefaultBrowserDevToolsPagePath}${query}";

@maraf
Copy link
Member Author

maraf commented Jun 16, 2025

/ba-g Failure is not related

@maraf maraf merged commit 2c349af into dotnet:main Jun 16, 2025
25 of 29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2025
@maraf maraf deleted the BrowserDebugUrl branch October 20, 2025 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants