Skip to content

Delete GetFirstNonVolatileRegisterAddress #117272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2025
Merged

Delete GetFirstNonVolatileRegisterAddress #117272

merged 5 commits into from
Jul 7, 2025

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Jul 3, 2025

  • Pass CONTEXT* to the CallEHFunclet instead
  • Cleanup magic constants in asm code used to fetch CONTEXT fields relative to the first non-volatile register position

@jkotas
Delete GetFirstNonVolatileRegisterAddress
2007c6d 
- Pass CONTEXT* to the CallEHFunclet instead
- Cleanup magic constants in asm code used to fetch CONTEXT fields relative to the first non-volatile register position
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Jul 3, 2025
Closed
jkotas
jkotas commented Jul 4, 2025
View reviewed changes
@risc-vv
Copy link

risc-vv commented Jul 4, 2025

@dotnet/samsung Could you please take a look? These changes may be related to riscv64.

jkotas
jkotas commented Jul 4, 2025
View reviewed changes
@filipnavara
Copy link
Member

@dotnet/samsung Robot stuck in an infinite loop?

6c56d24b-503a-4076-9aac-378f648ae1f2_text

@sirntar
Copy link
Member

sirntar commented Jul 4, 2025 •
edited
Loading

@filipnavara sorry, that was my mistake.... but well... now no one will forget about review ;)
(I will remove those comments)

jkotas
jkotas commented Jul 4, 2025
View reviewed changes
@risc-vv
Copy link

risc-vv commented Jul 4, 2025

cb5a903 is being scheduled for building and testing

GIT: cb5a90378164126617bed3c80dc57aacf44b83de
REPO: jkotas/runtime
BRANCH: GetFirstNonVolatileRegisterAddress

This was referenced Jul 4, 2025
Open
Open
@jkotas jkotas marked this pull request as ready for review July 4, 2025 21:09
@jkotas jkotas requested a review from janvorli July 4, 2025 21:09
@jkotas
Copy link
Member Author

jkotas commented Jul 4, 2025

This is prep work for applying #115284 to other architectures.

janvorli
janvorli approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

This was referenced Jul 7, 2025
Closed
Closed
@jkotas jkotas merged commit 6d8cffd into dotnet:main Jul 7, 2025
95 of 99 checks passed
@jkotas jkotas deleted the GetFirstNonVolatileRegisterAddress branch July 7, 2025 19:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorli janvorli janvorli approved these changes

Assignees

@jkotas jkotas

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jkotas @risc-vv @filipnavara @sirntar @janvorli