Move CoreCLR over to the managed wait subsystem #117788

jkoritzinsky · 2025-07-17T21:36:17Z

Use the shared managed wait subsystem for CoreCLR's managed code instead of the Win32 PAL

Also, remove the named mutex support from the CoreCLR PAL as nothing uses it now.

TODO: Once #117688 is in, we can remove Mutex support from the Win32 PAL entirely

Unblocks #115685

Depends on #117635

dotnet-policy-service · 2025-07-17T21:37:05Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

src/libraries/System.Private.CoreLib/src/System/Threading/LowLevelLifoSemaphore.Unix.cs

src/coreclr/vm/threads.cpp

src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs

src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetPageSize.cs

src/coreclr/vm/threads.cpp

…-managed-wait

src/coreclr/dlls/mscordac/mscordac_unixexports.src

eng/SignCheckExclusionsFile.txt

… logic is only for externally-attached threads)

src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs

… finalizer.

… Thread.Interrupt on non-Windows (it's not needed any more).

… them

am11 · 2025-11-03T21:47:22Z

src/coreclr/pal/src/config.h.in

-#cmakedefine01 HAVE_FULLY_FEATURED_PTHREAD_MUTEXES
-#cmakedefine01 HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES


These can be removed from:

eng/native/tryrun.cmake: set_cache_value(HAVE_FULLY_FEATURED_PTHREAD_MUTEXES 1) eng/native/tryrun.cmake: set_cache_value(HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES_EXITCODE 1) eng/native/tryrun.cmake: set_cache_value(HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES_EXITCODE 0) eng/native/tryrun.cmake: set_cache_value(HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES_EXITCODE 0) eng/native/tryrun.cmake: set_cache_value(HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES_EXITCODE 0) eng/native/tryrun.cmake: set_cache_value(HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES_EXITCODE 0) eng/native/tryrun_ios_tvos.cmake:set_cache_value(HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES_EXITCODE 1)

am11 · 2025-11-03T21:49:11Z

src/coreclr/vm/comsynchronizable.cpp

-
-extern "C" BOOL QCALLTYPE ThreadNative_Join(QCall::ObjectHandleOnStack thread, INT32 Timeout)
+#if TARGET_WINDOWS
+extern "C" HANDLE QCALLTYPE ThreadNative_GetOSHandle(QCall::ThreadHandle t);


Suggested change

extern "C" HANDLE QCALLTYPE ThreadNative_GetOSHandle(QCall::ThreadHandle t);

extern "C" HANDLE QCALLTYPE ThreadNative_GetOSHandle(QCall::ThreadHandle t)

jkotas · 2025-11-03T23:04:31Z

src/coreclr/vm/threads.cpp

+void
+ThreadCleanupThread::EnsureCleanupThreadExists()
+{
+    if (ForeignThreadsToCleanUpEvent == nullptr)


This can use contract. Can it throw?

jkotas · 2025-11-03T23:06:17Z

src/coreclr/vm/threads.cpp

+            pEvent.SuppressRelease();
+            Thread* pCleanupThread = SetupUnstartedThread();
+
+            if (pCleanupThread->CreateNewThread(0, &ForeignThreadCleanupThreadStart, NULL, W(".NET External Thread Cleanup Thread")))


Do we need to retry if any of this fails?

jkoritzinsky added area-System.Threading runtime-coreclr specific to the CoreCLR runtime labels Jul 17, 2025

dotnet-policy-service bot assigned jkoritzinsky Jul 17, 2025

jkoritzinsky mentioned this pull request Jul 17, 2025

[Android] Add support for named mutex on mobile platforms in CoreCLR #117760

Open

jkoritzinsky added this to the 11.0.0 milestone Jul 17, 2025

jkoritzinsky added the blocked Issue/PR is blocked on something - see comments label Jul 17, 2025

jkoritzinsky force-pushed the coreclr-managed-wait branch from 25446d0 to 63dc9af Compare July 21, 2025 19:44

jkoritzinsky force-pushed the coreclr-managed-wait branch 3 times, most recently from 06de3b2 to 63a1aa6 Compare July 31, 2025 16:44

This was referenced Jul 31, 2025

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

[browser] Wasm.Build.Tests timeout - Timed out after 10s waiting for 'WASM EXIT' #116697

Open

jkoritzinsky mentioned this pull request Aug 5, 2025

Move the implementation of Monitor to managed in CoreCLR #118371

Merged

teo-tsirpanis reviewed Aug 5, 2025

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Threading/LowLevelLifoSemaphore.Unix.cs Outdated Show resolved Hide resolved

jkotas reviewed Aug 7, 2025

View reviewed changes

src/coreclr/vm/threads.cpp Outdated Show resolved Hide resolved

jkoritzinsky force-pushed the coreclr-managed-wait branch from 63a1aa6 to 2b610bf Compare August 14, 2025 18:54

jkotas reviewed Aug 14, 2025

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas reviewed Aug 14, 2025

View reviewed changes

src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetPageSize.cs Outdated Show resolved Hide resolved

jkoritzinsky force-pushed the coreclr-managed-wait branch from 4a27a27 to ac08ce6 Compare August 14, 2025 23:13

jkotas reviewed Aug 14, 2025

View reviewed changes

src/coreclr/vm/threads.cpp Outdated Show resolved Hide resolved

jkotas reviewed Aug 15, 2025

View reviewed changes

src/coreclr/vm/threads.cpp Outdated Show resolved Hide resolved

jkoritzinsky added 3 commits October 30, 2025 09:38

Merge branch 'main' of https://github.com/dotnet/runtime into coreclr…

da2ef05

…-managed-wait

Remove OSEvent concept (unused)

c24ae0b

Remove Thread::Wait as it's unused now

f877b08

jkoritzinsky removed the blocked Issue/PR is blocked on something - see comments label Oct 30, 2025

Fix return from DoReentrantWaitAny

60bcece

jkoritzinsky force-pushed the coreclr-managed-wait branch from 2f66eeb to 60bcece Compare October 30, 2025 17:12

Remove special-cases in WaitHandle.cs for CoreCLR

a82112e

am11 reviewed Oct 30, 2025

View reviewed changes

src/coreclr/dlls/mscordac/mscordac_unixexports.src Show resolved Hide resolved

jkotas reviewed Oct 30, 2025

View reviewed changes

eng/SignCheckExclusionsFile.txt Outdated Show resolved Hide resolved

jkoritzinsky added 5 commits October 30, 2025 11:45

Fix messed up merge commit

4fe3f06

Remove export that no longer exists

8adc8c0

Interrupt the wait subsystem when Interrupt is called.

95a1ed3

Handle the standard .NET-owned thread case (apparently the "detached"…

6595959

… logic is only for externally-attached threads)

Fix invalidnames test now that the implementations are unified.

a563d38

jkotas reviewed Oct 31, 2025

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs Show resolved Hide resolved

jkotas reviewed Oct 31, 2025

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs Show resolved Hide resolved

build-analysis bot mentioned this pull request Oct 31, 2025

Android System.Security.Cryptography test failure: Signing key verifies the CRL #119023

Open

jkoritzinsky added 6 commits October 31, 2025 17:37

Clean up foreign threads in their own helper thread instead of on the…

d6d650c

… finalizer.

Move Thread.Join to managed and remove the call into CoreCLR's native…

9c6c00c

… Thread.Interrupt on non-Windows (it's not needed any more).

Remove support for altertable waits in the PAL now that we don't need…

da6ad45

… them

Delete now-unused SignalObjectAndWait from the PAL

5fda9a6

Set up the foreign cleanup thread on thread attach, not detach.

a0643f9

Remove duplicate Join

8971c9d

am11 reviewed Nov 3, 2025

View reviewed changes

jkotas reviewed Nov 3, 2025

View reviewed changes

This was referenced Nov 4, 2025

[android] Android.Device_Emulator.JIT.Test failing on emulators with CoreCLR #112633

Open

Failed to install runtime_python_requirements #114924

Open

AppHost test failure: I/O failure when writing extracted files #120653

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move CoreCLR over to the managed wait subsystem #117788

Move CoreCLR over to the managed wait subsystem #117788

jkoritzinsky commented Jul 17, 2025 •

edited

Loading

Uh oh!

dotnet-policy-service bot commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

am11 Nov 3, 2025

Uh oh!

am11 Nov 3, 2025

Uh oh!

jkotas Nov 3, 2025

Uh oh!

jkotas Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		#cmakedefine01 HAVE_FULLY_FEATURED_PTHREAD_MUTEXES
		#cmakedefine01 HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES

	extern "C" HANDLE QCALLTYPE ThreadNative_GetOSHandle(QCall::ThreadHandle t);
	extern "C" HANDLE QCALLTYPE ThreadNative_GetOSHandle(QCall::ThreadHandle t)

Move CoreCLR over to the managed wait subsystem #117788

Are you sure you want to change the base?

Move CoreCLR over to the managed wait subsystem #117788

Conversation

jkoritzinsky commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

am11 Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

am11 Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

jkotas Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

jkotas Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jkoritzinsky commented Jul 17, 2025 •

edited

Loading