Delete AppDomain::m_Stage #117857
Merged
Delete AppDomain::m_Stage #117857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Left-over from .NET Framework
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the AppDomain staging mechanism (m_Stage) that was a leftover from .NET Framework. The change simplifies the AppDomain implementation by eliminating the complex stage tracking system that is no longer needed in .NET Core/5+.
Key changes include:
- Removal of the
AppDomain::m_Stagemember variable and associatedStageenum - Deletion of
IsActive()andIsValid()methods that depended on stage checking - Simplification of AppDomain creation and initialization logic
- Update of function signatures to remove unnecessary
EXTERN_CandSTDCALLmodifiers
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/appdomain.hpp | Removes Stage enum, IsActive/IsValid methods, and m_Stage member variable |
| src/coreclr/vm/appdomain.cpp | Removes stage-related initialization and checks, simplifies contracts |
| src/coreclr/vm/threads.inl | Updates GetAppDomain function signature |
| src/coreclr/vm/common.h | Updates GetAppDomain declaration |
| src/coreclr/vm/profilingenumerators.cpp | Replaces IsActive() check with simple null check |
| src/coreclr/debug/daccess/request.cpp | Replaces dynamic stage with hardcoded STAGE_OPEN |
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
commented
Jul 20, 2025
Open
3 tasks
rcj1
approved these changes
Jul 20, 2025
Contributor
rcj1
left a comment
rcj1
left a comment
There was a problem hiding this comment.
LGTM aside from a redundant code line and some formatting
Contributor
|
👍 |
Member
Author
|
/ba-g infrastructure timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left-over from .NET Framework