[10.0-preview7] Serialize unhandled exception for crash dump analysis when ExceptionHandler.RaiseUnhandledExceptionEvent is called #117913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andler.RaiseUnhandledExceptionEvent is called (dotnet#117832) * Serialize unhandled exception for crash dump analysis when ExceptionHandler.RaiseUnhandledExceptionEvent is called * Use cheaper locking mechanism for SerializeCrashInfo * Remove superfluous assignment * Apply suggestions from code review Co-authored-by: Jan Kotas <[email protected]> * Block secondary calls to SerializeCrashInfo until the data has been serialized (prevents early process exit) * Update src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs * Update src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs --------- Co-authored-by: Jan Kotas <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR ports crash dump analysis improvements from main to the .NET 10 Preview 7 branch. The changes serialize unhandled exception information for crash dump analysis when ExceptionHandler.RaiseUnhandledExceptionEvent is called and implement a blocking mechanism to prevent early process exit during serialization.
Key changes:
- Adds crash info serialization for unhandled exceptions in NativeAOT scenarios
- Refactors crash info serialization into a reusable method with thread-safe coordination
- Implements blocking behavior to ensure crash data serialization completes before process termination
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/AppContext.cs | Adds call to serialize crash info when unhandled exceptions occur in NativeAOT |
| src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs | Refactors crash info serialization into reusable method with thread coordination and updates FailFast to use the new approach |
src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
approved these changes
Jul 22, 2025
This was referenced Jul 22, 2025
artl93
added
Servicing-approved
|
@tommcdon please take a look at the failures in ci. once ready, I can help merge |
jeffschwMSFT
merged commit 3836b79
into
dotnet:release/10.0-preview7
139 of 144 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #117832 from main to .NET 10 Preview 7 branch