Skip to content

Unquote primitive string values in JsonNode.ToString() #117993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025
Merged

Unquote primitive string values in JsonNode.ToString() #117993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab2b6ca
Unquote primitive string values in JsonNode.ToString()
PranavSenthilnathan Jul 23, 2025
57abcb3
Use switch statement for type checks
PranavSenthilnathan Jul 24, 2025
f847eef
Merge branch 'main' into unquote-jsonvalue-tostring
PranavSenthilnathan Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.To.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Threading;

namespace System.Text.Json.Nodes
{
public abstract partial class JsonNode
Expand Down Expand Up @@ -44,14 +42,14 @@ public override string ToString()
// Special case for string; don't quote it.
if (this is JsonValue)
{
if (this is JsonValuePrimitive<string> jsonString)
{
return jsonString.Value;
}

if (this is JsonValueOfElement { Value.ValueKind: JsonValueKind.String } jsonElement)
switch (this)
{
return jsonElement.Value.GetString()!;
case JsonValuePrimitive<string> jsonString:
return jsonString.Value;
case JsonValueOfElement { Value.ValueKind: JsonValueKind.String } jsonElement:
return jsonElement.Value.GetString()!;
case JsonValueOfJsonString jsonValueOfJsonString:
return jsonValueOfJsonString.GetValue<string>()!;
}
}

Expand Down
Loading
Loading