-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Emit IsAotCompatible attribute metadata #118008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This could be used for #117712 and is a useful piece of metadata. I was going back and forth between placing this here or somewhere in the dotnet/sdk repo but since this is related to the analyzer, it feels okay here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds automatic emission of the IsAotCompatible assembly attribute metadata for assemblies that are marked as AOT-compatible. This provides runtime metadata that can be used to identify AOT-compatible assemblies, supporting issue #117712.
Key Changes
- Adds conditional assembly attribute generation for
IsAotCompatiblemetadata when the MSBuild property$(IsAotCompatible)is set to true - Follows the same pattern as the existing
IsTrimmableattribute emission
|
Tagging subscribers to this area: @dotnet/illink |
sbomer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
/ba-g too many WASM failures to count |
This could be used for #117712 and is a useful piece of metadata.
I was going back and forth between placing this here or somewhere in the dotnet/sdk repo but since this is related to the analyzer, it feels okay here too.