Skip to content

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Jul 30, 2025

Defaults IsAotCompatible to true for ref projects, and moves the opt-out to be shared between src/ref projects.

Needed to flow AssemblyMetadata("IsAotCompatible", "True") to ref assemblies for #117712. Follow-up to #118149.

Similar to #118144 but for IsAotCompatible.

@sbomer sbomer requested review from a team, MichalStrehovsky, ViktorHofer and Copilot July 30, 2025 23:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the IsAotCompatible property configuration by defaulting it to true for both source and reference projects, and consolidates AOT compatibility opt-outs to shared Directory.Build.props files instead of individual project files.

Key changes:

  • Extends default AOT compatibility to reference assembly projects in addition to source projects
  • Moves IsAotCompatible=false declarations from individual .csproj files to shared Directory.Build.props files
  • Ensures consistent AOT compatibility metadata flows to both source and reference assemblies

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.

File Description
src/libraries/Directory.Build.props Updates default IsAotCompatible condition to include reference assembly projects
Multiple src/*.csproj files Removes individual IsAotCompatible=false declarations from project files
Multiple Directory.Build.props files Adds centralized IsAotCompatible=false opt-outs for library families

@sbomer sbomer changed the title Is aot compatible ref Default IsAotCompatible for ref projects Jul 30, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@sbomer sbomer merged commit 51a4123 into dotnet:main Jul 31, 2025
95 checks passed
@sbomer sbomer deleted the isAotCompatibleRef branch August 7, 2025 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants