Fix: Assert failure: Thread::IsObjRefValid #118307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an assert failure in Thread::IsObjRefValid by properly converting an Object pointer to an OBJECTREF using the appropriate conversion function. The issue occurs when handling constructor returns for variable-sized objects like strings.
Key Changes
- Updates object reference handling in
RuntimeMethodHandle_InvokeMethodto use proper type conversion - Replaces direct cast with
ObjectToOBJECTREFfunction call for better type safety
jkotas
commented
Aug 2, 2025
jkotas
added
area-VM-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @mangod9 |
AaronRobinsonMSFT
approved these changes
Aug 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117961