-
Couldn't load subscription status.
- Fork 5.2k
Disable canonicalization tests with native AOT #118676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are all incompatible with trimming and break native AOT outerloop runs. E.g. ``` [FAIL] System.Runtime.Serialization.Xml.Canonicalization.Tests.XmlCanonicalizationTest.TestC14NInclusivePrefixes System.TypeInitializationException : A type initializer threw an exception. To determine which type, inspect the InnerException's StackTrace property. ---- System.InvalidOperationException : There is an error in XML document (0, 0). -------- System.InvalidOperationException : There was an error reflecting type 'TestCasesConfig'. ------------ System.InvalidOperationException : You must implement a default accessor on System.Collections.Generic.List`1[[TestCase, System.Runtime.Serialization.Xml.Canonicalization.Tests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]] because it inherits from ICollection. at System.Runtime.CompilerServices.ClassConstructorRunner.EnsureClassConstructorRun(StaticClassConstructionContext*) + 0x16c at System.Runtime.CompilerServices.ClassConstructorRunner.CheckStaticClassConstructionReturnNonGCStaticBase(StaticClassConstructionContext*, IntPtr) + 0x14 at System.Runtime.Serialization.Xml.Canonicalization.Tests.XmlCanonicalizationTest.TestC14NInclusivePrefixes() + 0x80c at System.Runtime.Serialization.Xml.Canonicalization!<BaseAddress>+0x720cdc at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x114 ----- Inner Stack Trace ----- at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader, String, XmlDeserializationEvents) + 0x1f8 at System.Xml.Serialization.XmlSerializer.Deserialize(Stream) + 0x9c at TestConfigHelper.LoadAllTests(String path) + 0x78 at System.Runtime.CompilerServices.ClassConstructorRunner.EnsureClassConstructorRun(StaticClassConstructionContext*) + 0xbc ----- Inner Stack Trace ----- at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(TypeModel, String, XmlReflectionImporter.ImportContext, String, XmlAttributes, Boolean, Boolean, RecursionLimiter) + 0x59c at System.Xml.Serialization.XmlReflectionImporter.ImportElement(TypeModel, XmlRootAttribute, String, RecursionLimiter) + 0xa0 at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(Type, XmlRootAttribute, String) + 0x8c at System.Xml.Serialization.XmlSerializer.GetMapping() + 0x58 at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader, String, XmlDeserializationEvents) + 0x6c ----- Inner Stack Trace ----- at System.Xml.Serialization.TypeScope.GetDefaultIndexer(Type, String) + 0x284 at System.Xml.Serialization.TypeScope.ImportTypeDesc(Type, MemberInfo, Boolean) + 0x66c at System.Xml.Serialization.TypeScope.GetTypeDesc(Type, MemberInfo, Boolean, Boolean) + 0x100 at System.Xml.Serialization.StructModel.GetFieldModel(FieldInfo) + 0x78 at System.Xml.Serialization.StructModel.GetFieldModel(MemberInfo) + 0x68 at System.Xml.Serialization.XmlReflectionImporter.InitializeStructMembers(StructMapping, StructModel, Boolean, String, RecursionLimiter) + 0x5d4 at System.Xml.Serialization.XmlReflectionImporter.ImportStructLikeMapping(StructModel, String, Boolean, XmlAttributes, RecursionLimiter) + 0x228 at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(TypeModel, String, XmlReflectionImporter.ImportContext, String, XmlAttributes, Boolean, Boolean, RecursionLimiter) + 0x218 ```
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
/ba-g the change is not exercised by the CI and need to unblock outerloops |
These are all incompatible with trimming and break native AOT outerloop runs. E.g.
Cc @dotnet/ilc-contrib