[cDAC] Correct EnumMethodInstancesByAddress HResult

[max-charlamb]

Follow up to #115131

Noticed some test failures in CI after merging. This should resolve those failures.

• Modifies ulong -> ClrDataAddress
• Handles read failures and returns proper error code

[Copilot]

Pull Request Overview

This PR corrects the HResult handling and parameter types for the EnumMethodInstancesByAddress method in the cDAC implementation. The changes address test failures that occurred after a previous merge by ensuring proper error handling and type consistency.

Key changes:

• Updates parameter type from ulong to ClrDataAddress for better type safety
• Adds proper exception handling for target read failures with appropriate error codes
• Ensures consistent address handling throughout the method implementation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
SOSDacImpl.IXCLRDataProcess.cs	Updates method signature, adds proper address conversion, and implements exception handling for read failures
IXCLRData.cs	Updates interface method signature to use ClrDataAddress instead of ulong

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[noahfalk]

This looks fine to me though I am surprised cDac is turning a read failure into an InvalidOperationException in the first place. I would have anticipated cDac to define an explicit exception type for read memory failure and throw that.

[max-charlamb]

This looks fine to me though I am surprised cDac is turning a read failure into an InvalidOperationException in the first place. I would have anticipated cDac to define an explicit exception type for read memory failure and throw that.

Agreed. I was talked with @rcj1 earlier about changing read/write failures to specific exceptions so we can handle them.

[max-charlamb]

Closing in favor of #118895