Delete dead code in superpmi #118717
Merged
Delete dead code in superpmi #118717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR removes dead code related to the GetTypeForBoxOnStack functionality from the SuperPMI tool in the CoreCLR repository. SuperPMI is a tool used for JIT compiler testing and replay.
- Removes unused
GetTypeForBoxOnStackmethod declarations and implementations - Comments out the corresponding packet enum value to maintain compatibility
- Removes the associated lightweight map entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| methodcontext.h | Removes method declarations for recGetTypeForBoxOnStack, dmpGetTypeForBoxOnStack, and repGetTypeForBoxOnStack; comments out packet enum |
| methodcontext.cpp | Removes complete implementation of the three GetTypeForBoxOnStack methods |
| lwmlist.h | Removes the GetTypeForBoxOnStack lightweight map entry |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Aug 14, 2025
jakobbotsch
approved these changes
Aug 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.