Disable async test assert with race condition #118735
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
|
This assert failed in #118726 |
There was a problem hiding this comment.
Pull Request Overview
This PR disables a flaky async test assertion that has a race condition. The test is temporarily commented out until the underlying Roslyn compiler can emit the ConfigureAwait call as a runtime async operation, which would eliminate the timing issue.
Key Changes:
- Comments out two lines of test code that were causing race conditions
- Adds explanatory comment describing why the test is disabled and when it can be re-enabled
VSadov
reviewed
Aug 14, 2025
|
@jakobbotsch, just a heads up, #118810 (PR is targeting rc1 branch) has picked up the roslyn change dotnet/roslyn@caeac86. |
This was referenced Aug 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to enable this testing once we switch to a Roslyn that emits this as a runtime async call.