[release/10.0] JIT: Consistently DNER promoted parameters on arm32 #119055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lvaGetPromotionType` always returns dependent promotion for this case, but `lvDoNotEnregister` was not consistently set. With this PR we instead consistently just set `lvDoNotEnregister` for these parameters.
jeffschwMSFT
added
the
area-CodeGen-coreclr
jeffschwMSFT
approved these changes
Aug 26, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. we can merge when ready
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
JulieLeeMSFT
approved these changes
Aug 27, 2025
Member
|
@jakobbotsch can you take a look at the failing ci? |
Member
|
The failures are #116014 (I don't know why build analysis is blocking, all the failures are known.) |
Member
|
/ba-g Failures are known |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #118953 to release/10.0
/cc @jakobbotsch
Customer Impact
The JIT inconsistently marks some locals as not being register candidates on arm32 which leads to unpredictable results. The new runtime async transformation produces IR that the backend does not expect to see because of the inconsistency.
Regression
Testing
Issue found and testing done via fuzzing.
Risk
Low.