[release/10.0] [EventPipe][UserEvents] Allow empty tracepoint sets #119666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffschwMSFT
approved these changes
Sep 14, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. we can merge when ready
jeffschwMSFT
added
Servicing-approved
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Member
|
Looks like Build Analysis did find the related issue, but didn't actually turn green? Is that because the table wasn't updated in the known issue? |
steveisok
approved these changes
Sep 15, 2025
Member
|
@mdh1418 - build analysis doesn't do that on release branches. |
hoyosjs
approved these changes
Sep 15, 2025
Member
|
/ba-g all issues are known - this is a release branch which doesn't turn green automatically. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119651 to release/10.0
/cc @mdh1418
Customer Impact
This impacts user_events-based EventPipe Sessions, which is a .NET 10 Linux-only feature.
Before the change, valid IPC command payloads to start a user_events-based eventpipe session would be incorrectly deemed invalid and thus the session wouldn't start.
Specifically, the specification at https://github.com/dotnet/diagnostics/blob/main/documentation/design-docs/ipc-protocol.md#user_events-session-payload dictates that the
tracepoint_setspayload portion can be empty if the default_tracepoint_name was present, but the previous logic considered that invalid.The expectation is that just specifying the default tracepoint name and 0 tracepoint sets for a provider configuration would still kickoff a user_events-based eventpipe session.
Regression
Testing
Manually tested with custom script to send an IPC command.
Risk
Low. The change affects the IPC command parsing logic for user_events-based eventpipe sessions, a .NET 10 feature. Previously, some payloads were incorrectly deemed invalid, preventing user_events-based eventpipe sessions from being started. Now, the runtime will deem them valid and allow the eventpipe session to start.