[release/9.0-staging] Prevent format injection in hosting Windows PAL printf functions when redirected to file #119786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… redirected to file
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a format injection vulnerability in the hosting Windows PAL printf functions when output is redirected to a file. The issue occurs when paths in deps.json or framework names in runtimeconfig.json contain '%' characters, which are interpreted as format specifiers and can cause crashes.
- Replaces direct
pal::file_vprintfcall with a saferfile_printfwrapper that uses%sformat specifier - Adds a new
file_printfhelper function to properly handle string formatting - Prevents format injection attacks when trace output is redirected to files
|
Approved. Please get code review and check test results. |
JulieLeeMSFT
added
the
Servicing-consider
jkotas
approved these changes
Sep 17, 2025
This was referenced Sep 17, 2025
Open
|
CC @jeffschwMSFT. |
rbhanda
added
Servicing-approved
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g failures matched to existing issue, but BA is not green because this is a servicing branch |
jkoritzinsky
merged commit 836cc98
into
dotnet:release/9.0-staging
150 of 154 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #119566
main PR #119568
Description
Customer Impact
Prevents crashes when a path in deps.json or a framework name in runtimeconfig.json contains a '%' character.
Regression
Yes, introduced by #102295
Testing
Manual validation with testing
Risk
Low risk. This is a standard fix for this scenario, and it's only reachable on .NET 9 with an opt-in
COREHOST_TRACE=1environment variable.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.