Centralize vararg test exclusions #119878
Conversation
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes and consolidates vararg test exclusions across the test suite. Previously, vararg-related test exclusions were scattered throughout different platform-specific sections of the issues.targets file with inconsistent conditions and duplicate entries.
Key changes:
- Consolidates all vararg test exclusions into a single section with unified conditions
- Updates conditional logic to exclude tests on non-Windows platforms OR when using NativeAOT
- Removes ARM-specific test project files that are no longer needed
- Updates platform detection logic to allow varargs on ARM Windows platforms
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/issues.targets | Consolidates scattered vararg exclusions into single section with unified conditions |
| src/tests/JIT/Directed/arglist/vararg_TargetUnix.csproj | Removes Unix-specific vararg test project (entire file deleted) |
| src/tests/JIT/Directed/arglist/vararg_TargetWindows.csproj | Updates comment from "arglist IL opcode" to "varargs" |
| src/tests/JIT/Directed/PREFIX//arglist_Target_ARM_.ilproj | Removes ARM-specific test project files (multiple files deleted) |
| src/tests/JIT/Directed/PREFIX/*/arglist_Target_BIT_.ilproj | Updates comments and removes ARM exclusion conditions |
| src/tests/JIT/Directed/PREFIX/*/arglistARM.il | Removes ARM-specific IL test files (multiple files deleted) |
| src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs | Updates IsArgIteratorSupported to allow varargs on ARM Windows |
src/tests/JIT/Directed/PREFIX/unaligned/1/arglist_Target_32BIT_unaligned_1.ilproj
Show resolved
Hide resolved
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@janvorli Could you please take a look? I have replaced the piecemeal conditions to disable vararg tests with unform dynamic check. It is self-documenting and allows us to enable/disable vararg testing as needed. I think we should adopt the same style for other features that are not universally available and that number of tests depend on, like exception interop discussed in the other PR. |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g infrastructure timeouts |
3 participants
No description provided.