Miscellaneous cleanup #120184
Merged
Miscellaneous cleanup #120184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR performs miscellaneous cleanup tasks across the codebase, including code simplification, removal of unused functionality, and style consistency improvements.
Key changes include:
- Removal of unused COM apartment initialization code from CoreCLR
- Simplification of platform detection logic
- Code style and formatting improvements in API reference files
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Runtime.Loader/ref/System.Runtime.Loader.cs | Reformatted API reference with consistent attribute syntax and namespace organization |
| src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs | Simplified ArgIterator support detection by removing ARM process check |
| src/coreclr/vm/threads.h | Removed unused COM apartment initialization task definitions and methods |
| src/coreclr/vm/threads.cpp | Added preprocessor guards and removed COM initialization calls |
| src/coreclr/vm/methodtablebuilder.cpp | Simplified comment about fcalls RVA requirement |
| src/coreclr/vm/jitinterface.cpp | Removed unused inline helper function and inlined its usage |
| src/coreclr/vm/interoputil.h | Removed unused parameters from COM startup function declarations |
| src/coreclr/vm/interoputil.cpp | Removed unused parameters from COM startup function implementations |
| src/coreclr/vm/finalizerthread.cpp | Removed unused COM apartment initialization code from finalizer thread |
| src/coreclr/vm/dllimport.cpp | Fixed typo in comment ("diable" to "disable") |
| src/coreclr/vm/comsynchronizable.cpp | Removed COM startup logic from apartment state detection |
|
Tagging subscribers to this area: @mangod9 |
mangod9
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions for details.