[mono][hotreload] Ignore if we receive an empty update. #120333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a check to ignore empty hot reload updates in the Mono runtime. This prevents unnecessary processing when ASP.NET Core sends empty updates in WebAssembly debugger scenarios where the debugger itself applies the real updates.
Key Changes
- Added early return when both metadata and IL byte counts are zero
- Prevents redundant processing of empty hot reload updates
Co-authored-by: Copilot <[email protected]>
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18202185862 |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/18202189764 |
steveisok
approved these changes
Oct 2, 2025
|
Do we need a test? |
Can we pull that off in runtime? |
I think it's not possible to add a test here. Not super sure. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to ignore empty hot reload updates in the Mono runtime. This prevents unnecessary processing when ASP.NET Core sends empty updates in WebAssembly debugger scenarios where the debugger itself applies the real updates.
And also avoids assertion for receiving updates from System.Reflection.Metadata.MetadataUpdater.ApplyUpdate and from debugger even if one of them was empty.