Skip to content

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Oct 3, 2025

Contributes to #120353

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@vcsjones vcsjones changed the title Detected is RSA-384 is supported on the platform Detected if RSA-384 is supported on the platform Oct 3, 2025
@vcsjones vcsjones changed the title Detected if RSA-384 is supported on the platform Detect if RSA-384 is supported on the platform Oct 3, 2025
@bartonjs
Copy link
Member

bartonjs commented Oct 3, 2025

It's draft, but currently LGTM (FWIW).

@vcsjones vcsjones marked this pull request as ready for review October 3, 2025 18:11
Copilot AI review requested due to automatic review settings October 3, 2025 18:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes RSA-384 support detection across different RSA provider implementations by introducing a new PlatformSupport.IsRSA384Supported property. The change eliminates duplicated platform detection logic and provides a unified approach for determining RSA-384 support.

Key changes:

  • Added centralized RSA-384 support detection in PlatformSupport class
  • Replaced provider-specific RSA-384 support checks with calls to the centralized property
  • Removed duplicated platform detection code from individual RSA provider classes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs Added IsRSA384Supported property with platform-specific detection logic and RSA-384 test parameters
src/libraries/System.Security.Cryptography/tests/DefaultRSAProvider.cs Replaced custom RSA-384 support detection with centralized PlatformSupport.IsRSA384Supported
src/libraries/System.Security.Cryptography.Csp/tests/RSACryptoServiceProviderProvider.cs Changed from hardcoded true to use centralized RSA-384 support detection
src/libraries/System.Security.Cryptography.Cng/tests/RSACngProvider.cs Replaced custom RSA-384 support detection with centralized PlatformSupport.IsRSA384Supported

@vcsjones vcsjones enabled auto-merge (squash) October 3, 2025 18:41
@vcsjones
Copy link
Member Author

vcsjones commented Oct 3, 2025

The Windows pipeline did not have these failures so enabled automatic merge.

@vcsjones vcsjones merged commit 51ca4ba into dotnet:main Oct 3, 2025
84 of 86 checks passed
@vcsjones vcsjones deleted the rsa-fix-384-tests branch October 3, 2025 19:37
@vcsjones
Copy link
Member Author

vcsjones commented Oct 3, 2025

/backport to release/10.0

@vcsjones
Copy link
Member Author

vcsjones commented Oct 3, 2025

/backport to release/9.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18232060822

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/18232062344

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

@vcsjones backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Detected is RSA-384 is supported on the platform
Using index info to reconstruct a base tree...
M	src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Detected is RSA-384 is supported on the platform
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

@vcsjones backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Detected is RSA-384 is supported on the platform
Using index info to reconstruct a base tree...
M	src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Applying: Fix M.B.C compilation
Using index info to reconstruct a base tree...
M	src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Fix M.B.C compilation
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@vcsjones
Copy link
Member Author

vcsjones commented Oct 3, 2025

Boo. This would backport cleanly if the patch was squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Security test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants