Skip to content

[clr-interp] Fail with a BADCODE if the opcode is unknown #120391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

[clr-interp] Fail with a BADCODE if the opcode is unknown #120391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/coreclr/interpreter/compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,12 @@ bool IsInterpDumpActive()

void AssertOpCodeNotImplemented(const uint8_t *ip, size_t offset)
{
#ifdef DEBUG
fprintf(stderr, "IL_%04x %-10s - opcode not supported yet\n",
(int32_t)(offset),
CEEOpName(CEEDecodeOpcode(&ip)));
assert(!"opcode not implemented");
#endif // DEBUG
BADCODE("opcode not implemented");
}

// GCInfoEncoder needs an IAllocator implementation. This is a simple one that forwards to the Compiler.
Expand Down Expand Up @@ -4464,8 +4466,7 @@ void InterpCompiler::EmitStaticFieldAddress(CORINFO_FIELD_INFO *pFieldInfo, CORI
break;
}
default:
// TODO
assert(!"Unsupported (yet) static field accessor");
BADCODE("Unsupported static field accessor");
break;
}

Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/interpreter/intops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ const uint32_t g_CEEOpNameOffsets[] = {

const char* CEEOpName(OPCODE op)
{
if (op >= (sizeof(g_CEEOpNameOffsets) / sizeof(g_CEEOpNameOffsets[0])))
return "unused";
return ((const char*)&g_CEEOpNameCharacters) + g_CEEOpNameOffsets[op];
}

Expand Down