Avoid referencing types of JsonIgnore'd properties. #120543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the System.Text.Json source generator to avoid referencing types of JsonIgnore'd properties unless the type is already used elsewhere in the type graph. This prevents inadvertent referencing of types marked as experimental in the source generator.
- Updates source generator logic to use stub
JsonPropertyInfo<object>for ignored properties of unused types - Adds test infrastructure improvements with logging support
- Includes new test cases for experimental types with JsonIgnore
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| System.Text.Json.SourceGeneration.Roslyn4.4.Unit.Tests.csproj | Updates Roslyn API version from 4.4 to 4.8 |
| JsonSourceGeneratorTests.cs | Adds logging support and new test methods for experimental type scenarios |
| CompilationHelper.cs | Adds logging infrastructure and diagnostic output capabilities |
| JsonSourceGenerator.Emitter.cs | Core logic changes to avoid referencing types of ignored properties |
...ies/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/CompilationHelper.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
stephentoub
reviewed
Oct 8, 2025
stephentoub
reviewed
Oct 8, 2025
...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 8, 2025
...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
jeffhandley
approved these changes
Oct 8, 2025
...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
force-pushed
the
generator-skip-ignored-members
branch
from
357b2fc to
3ff1732
Compare
Co-authored-by: Copilot <[email protected]>
This reverts commit ed3bcc3.
jeffhandley
approved these changes
Oct 9, 2025
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18384128909 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the source generator so that generated code does not reference types of JsonIgnore'd properties unless the type is already present elsewhere in the type graph. Instead, it replaces the ignored property with a stub
JsonPropertyInfo<object>instance which is necessary for certain runtime validations performed by the serializer. This prevents inadvertent referencing of types marked as experimental in the source generator.