Fix NumberFormatInfoGroupSize test #120546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes test failures on Apple operating systems (macOS) for the ur-IN culture by updating the NumberFormatInfoNumberGroupSizes test to accept multiple valid values for number group sizes, accounting for changes in the underlying globalization data across different platforms.
Key Changes:
- Updated test data to include both old and new expected values for
ur-INculture - Modified test method to validate against multiple acceptable values instead of a single expected value
- Enhanced error messages to display both acceptable values and the culture name for better debugging
...untime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs
Show resolved
Hide resolved
...untime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs
Show resolved
Hide resolved
...untime/tests/System.Globalization.Tests/NumberFormatInfo/NumberFormatInfoNumberGroupSizes.cs
Outdated
Show resolved
Hide resolved
jeffhandley
approved these changes
Oct 8, 2025
This was referenced Oct 8, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120528, #118850, #117421
This test was failing on macOS and other Apple operating systems when using the
ur-INculture, due to changes in the underlying globalization data on those platforms. The fix updates the test to accept the new values in addition to the old ones used on other operating systems.