Implement bit manipulation API for BFloat16 #120602
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
huoyaoyuan
added
area-System.Numerics
new-api-needs-documentation
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
xtqqczze
reviewed
Oct 10, 2025
| public static BFloat16 ReadBFloat16BigEndian(ReadOnlySpan<byte> source) | ||
| { | ||
| return BitConverter.IsLittleEndian ? | ||
| BitConverter.Int16BitsToBFloat16(ReverseEndianness(MemoryMarshal.Read<short>(source))) : |
There was a problem hiding this comment.
Suggested change
| BitConverter.Int16BitsToBFloat16(ReverseEndianness(MemoryMarshal.Read<short>(source))) : | |
| BitConverter.UInt16BitsToBFloat16(ReverseEndianness(MemoryMarshal.Read<ushort>(source))) : |
Should we using UInt16 everywhere to match the field type?
There was a problem hiding this comment.
The current changes are at least consistent with ReadHalfLittleEndian, which is implemented with Int16 even though it's field is UInt16.
There was a problem hiding this comment.
Yes, I just duplicated everything from Half.
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #119874.
Contains missing API in #119874 (comment). Please confirm whether it needs reiterating through API review.