Skip to content

Improve error message when seeking to negative position in FileStream #120626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2025
Merged

Improve error message when seeking to negative position in FileStream #120626

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
264f1a1
Initial plan
Copilot Oct 11, 2025
9a45d72
Improve OSFileStreamStrategy Seek error message for negative positions
Copilot Oct 11, 2025
c115384
Add test to verify clear error message for negative seek positions
Copilot Oct 11, 2025
ffab470
Remove test that validates exception message content
Copilot Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/IO/Strategies/OSFileStreamStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ public sealed override long Seek(long offset, SeekOrigin origin)
}
else
{
// keep throwing the same exception we did when seek was causing actual offset change
FileStreamHelpers.ThrowInvalidArgument(_fileHandle);
// keep throwing the same exception type we did when seek was causing actual offset change
throw new IOException(SR.IO_SeekBeforeBegin);
}

// Prevent users from overwriting data in a file that was opened in append mode.
Expand Down
Loading