Address upcoming breaking change for span-valued collection expressions #120771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an upcoming breaking change in C# related to the safe-context rules for span-valued collection expressions. The change modifies how collection expressions for Span/ReadOnlySpan types are handled when passed to constructors or methods.
Key Changes:
- Extracts a span-valued collection expression from within a conditional block to the top level of the method to comply with new safe-context rules
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
stephentoub
reviewed
Oct 15, 2025
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorShape.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 15, 2025
tannergooding
approved these changes
Oct 15, 2025
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18543984013 |
4 tasks
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc for upcoming breaking change
See dotnet/roslyn#80684. TensorShape's constructor was the only break I found when compiling the libraries. I fixed this by extracting the collection-expression to the top level.