Add flags for overflow on clang. #120775
Add flags for overflow on clang. #120775
Conversation
In clang-20 there is a known breaking change to -fwrapv that impacted us. Details can be found at https://releases.llvm.org/20.1.0/tools/clang/docs/ReleaseNotes.html#potentially-breaking-changes. Add the -fno-strict-aliasing to match our MSVC usage as well.
|
/cc @rnkovacs |
|
Tagging subscribers to this area: @mangod9 |
|
We should have a build image with clang 21 now: dotnet/dotnet-buildtools-prereqs-docker#1516 You can try updating all |
|
Last CI run still used clang 20: New images were built a few hours ago dotnet/dotnet-buildtools-prereqs-docker#1516 (comment) (it doesn't automatically rebuild the subtree). |
|
@jkotas, looks like we need to apply: --- a/src/native/libs/System.Security.Cryptography.Native/pal_x509.c
+++ b/src/native/libs/System.Security.Cryptography.Native/pal_x509.c
@@ -1250,6 +1250,7 @@ static int32_t X509ChainVerifyOcsp(X509_STORE_CTX* storeCtx, X509* subject, X509
{
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wcast-qual"
+#pragma clang diagnostic ignored "-Wimplicit-void-ptr-cast"
if (i2d_OCSP_RESPONSE_bio(bio, resp))
#pragma clang diagnostic pop
{ |
|
FreeBSD build fix: --- a/src/native/libs/System.Native/pal_interfaceaddresses.c
+++ b/src/native/libs/System.Native/pal_interfaceaddresses.c
@@ -561,7 +561,7 @@ int32_t SystemNative_EnumerateGatewayAddressesForInterface(void* context, uint32
return -1;
}
- uint8_t* buffer = malloc(byteCount);
+ uint8_t* buffer = (uint8_t*)malloc(byteCount);
if (buffer == NULL)
{
errno = ENOMEM;
@@ -587,7 +587,7 @@ int32_t SystemNative_EnumerateGatewayAddressesForInterface(void* context, uint32
byteCount = tmpEstimatedSize;
free(buffer);
- buffer = malloc(byteCount);
+ buffer = (uint8_t*)malloc(byteCount);
if (buffer == NULL)
{
errno = ENOMEM; |
|
It would be nice to update tables in https://github.com/dotnet/runtime/blob/f0db8f9d9668ba03897739152d02623acbd04466/docs/workflow/using-docker.md at the same time (replace |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a breaking change in clang-20 related to the -fwrapv flag by updating compiler flags and adding explicit casts to resolve warnings. The changes ensure compatibility with clang-20 while maintaining consistent behavior with MSVC by adding -fno-strict-aliasing.
Key Changes:
- Updated compiler flags in CMake configuration to use
-fno-strict-overflowinstead of-fwrapvfor clang-20 compatibility - Added explicit casts to suppress implicit void pointer cast warnings in native code
- Updated Docker container images from net10.0 to net11.0 across build infrastructure
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/native/configurecompiler.cmake | Replaced -fwrapv with -fno-strict-overflow and added -fno-strict-aliasing to match MSVC behavior |
| src/native/libs/System.Security.Cryptography.Native/pal_x509.c | Added pragma to ignore -Wimplicit-void-ptr-cast warning |
| src/native/libs/System.Security.Cryptography.Native/opensslshim.h | Added explicit X509* cast to sk_X509_pop macro return value |
| src/native/libs/System.Native/pal_interfaceaddresses.c | Added explicit uint8_t* casts to malloc calls |
| eng/pipelines/common/templates/pipeline-with-resources.yml | Updated Docker images from net10.0 to net11.0 |
| docs/workflow/using-docker.md | Updated Docker image references in documentation from net10.0 to net11.0 |
|
/azp list |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 participants
In clang-20 there is a known breaking change to
-fwrapvthat impacted us. Details can be found at https://releases.llvm.org/20.1.0/tools/clang/docs/ReleaseNotes.html#potentially-breaking-changes.Add the
-fno-strict-aliasingto match our MSVC usage as well.Fixes #119706