-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add documentation for Java interop types. #120964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Java interop types. #120964
Conversation
|
@ericstj The |
|
/cc @dotnet/interop-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds XML documentation comments to three Java interop types in System.Private.CoreLib to improve API documentation clarity. The changes address issue #120504 by documenting the purpose and members of types used in Java-to-.NET cross-reference processing.
Key changes:
- Added type-level documentation for
StronglyConnectedComponent,MarkCrossReferencesArgs, andComponentCrossReference - Added field-level documentation for all members of
MarkCrossReferencesArgs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| StronglyConnectedComponent.cs | Added type-level summary describing the struct's role in cross-reference processing |
| MarkCrossReferencesArgs.cs | Added type-level summary and documentation for all four fields (ComponentCount, Components, CrossReferenceCount, CrossReferences) |
| ComponentCrossReference.cs | Added type-level summary describing cross-references between component groups |
...es/System.Private.CoreLib/src/System/Runtime/InteropServices/Java/MarkCrossReferencesArgs.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/interop-contrib |
...es/System.Private.CoreLib/src/System/Runtime/InteropServices/Java/MarkCrossReferencesArgs.cs
Outdated
Show resolved
Hide resolved
|
/ba-g Unrelated failures for outerloop |
I did this a few days back as part of an earlier pass at filling gaps. Was trying to leverage copilot to do it. #120670 |
Fixes #120504