Revert "Revert "Move hosting tests to XUnit 3""

[agocke]

Reverts #120997

[dotnet-policy-service]

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

[agocke]

@jkoritzinsky Looks like the tests are trying to pull the host from NuGet, but I would expect the host to be part of our bootstrap. Is that correct? Or do we not yet build the host in the bootstrap?

[jkoritzinsky]

It looks like we do build the host, but we don't hook up the right logic in targetingpacks.targets for the bootstrapped apphost to be found.

This target needs to be updated:

runtime/eng/targetingpacks.targets

Line 136 in 5efa15f

<Target Name="UpdateLocalAppHostPack"

It should do something like the target for the ref/targeting packs (use UseBootstrapLayout to determine which apphost to use):

runtime/eng/targetingpacks.targets

Lines 97 to 104 in 5efa15f

	<PropertyGroup Condition="'$(UseBootstrapLayout)' != 'true'">
	<LocalRefPackDir>$(MicrosoftNetCoreAppRefPackDir)</LocalRefPackDir>
	<LocalRuntimePackDir>$(MicrosoftNetCoreAppRuntimePackDir)</LocalRuntimePackDir>
	</PropertyGroup>
	<PropertyGroup Condition="'$(UseBootstrapLayout)' == 'true'">
	<LocalRefPackDir>$(BootstrapRefPackDir)</LocalRefPackDir>
	<LocalRuntimePackDir>$(BootstrapRuntimePackDir)</LocalRuntimePackDir>
	</PropertyGroup>

[jkoritzinsky]

I meant that we need to make sure that LocalAppHostPath is set to the bootstrapped one.

For the Host xunit tests, we should also set those projects to have UseBoootstrapLayout=true when UseBootstrap=true.

[jkoritzinsky]

Do we always want the apphost tests using the live apphost, or only on bootstrap (where we don't have an LKG host)?

[agocke]

Oh is importing this target alone enough to override? I only intended to use the bootstrap apphost for platforms with no lkg

[jkoritzinsky]

I think you need to explicitly opt out by setting UseLocalTargetingRuntimePack to false for the cases where we want to use the LKG.