You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwapnilGaikwad
changed the title
Fix failing NaN comparisons in Sve2.ConvertTo* tests
Arm64: [SVE] Fix failing NaN comparisons in Sve2.ConvertTo* tests
Nov 17, 2025
It would be useful, cheers. However, the other Sve2_ShiftArithmeticSaturate* tests would still fail. Up to you if you want to wait until those are fixed.
I though that the changes made here for eng/pipelines/coreclr/hardware-intrinsics.yml meant that the hardware instrinsic tests would all automatically be run for any PR that touches eng/pipelines/**, src/coreclr/jit/**, src/tests/Common/GenerateHWIntrinsicTests/**, src/tests/JIT/HardwareIntrinsics/**
I though that the changes made here for eng/pipelines/coreclr/hardware-intrinsics.yml meant that the hardware instrinsic tests would all automatically be run for any PR that touches eng/pipelines/**, src/coreclr/jit/**, src/tests/Common/GenerateHWIntrinsicTests/**, src/tests/JIT/HardwareIntrinsics/**
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
SwapnilGaikwad
changed the title
Contribute towards #121659
This PR fixes the NaN comparisons that were incorrectly handled in ConvertTo* tests as highlighted in the following screenshot.
Failure output.
@dotnet/arm64-contrib @a74nh @EgorBo