Revert "Revert "Dynamic generic dictionary expansion feature (#32270) #33343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I couldn't add an area label to this PR. Checkout this page to find out which area owner to ping, or please add exactly one area label to help train me in the future. |
jkotas
commented
Mar 8, 2020
src/coreclr/src/vm/genericdict.cpp
Outdated
| } | ||
| CONTRACT_END; | ||
|
|
||
| Dictionary* pDictionary = pMD->GetMethodDictionary(); |
Member
Author
There was a problem hiding this comment.
This is where the race condition was. We have fetched the Dictionary, then some other thread expanded the dictionary, and then we fetched the number of slot from the new Dictionary; but still kept using the old Dictionary.
Contributor
There was a problem hiding this comment.
Thanks Jan for tracking this down!
Member
Author
|
@fadimounir I have done detailed review of the code, and I believe that I have found the race condition. See the comment above. I have also tightened up the implementation in a few places as I was doing it. |
fadimounir
approved these changes
Mar 9, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32828