Add string ctor to MemberNotNull #33864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let’s vet with LDM. We’ll need a compiler change to recognize these new constructors. |
stephentoub
added
the
NO-MERGE
stephentoub
force-pushed
the
membernotnullctor
branch
from
98c3de7 to
b933f39
Compare
Member
|
Corresponding compiler change: dotnet/roslyn#42712 |
jcouv
reviewed
Mar 24, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/NullableAttributes.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Mar 24, 2020
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (iteration 1)
stephentoub
force-pushed
the
membernotnullctor
branch
from
b933f39 to
a57bbd0
Compare
stephentoub
removed
the
NO-MERGE
With only the params string[] ctor, every usage of MemberNotNull{When} in a CLSCompliant(true) assembly needs to have its warning suppressed.
stephentoub
force-pushed
the
membernotnullctor
branch
from
a57bbd0 to
8b971d6
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With only the params string[] ctor, every usage of MemberNotNull in a CLSCompliant(true) assembly needs to have its warning suppressed.
cc: @jcouv, @terrajobst
Relates to dotnet/roslyn#41438