[mono] Don't throw inheritance error on interfaces in GetCustomAttrs #33942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoffeeFlux
requested review from
EgorBo,
akoeplinger,
marek-safar,
steveisok and
vargaz
as code owners
lambdageek
approved these changes
Mar 23, 2020
Contributor
Author
|
@stephentoub can you check the test and make sure it's in the right place? Wasn't sure where to put it. |
akoeplinger
reviewed
Mar 24, 2020
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
I think I'd put it somewhere after
src/libraries/System.Runtime/tests/System/Type/TypeTests.Get.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Type/TypeTests.Get.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
From what I could tell, the GetCustomAttributes tests were all in the file for their parent class since their behavior differs some (e.g. MemberInfo tests have a bunch), which is why I put it here but wasn't sure. Can move if you still think that's the best place for it, and I'll fix the style. |
Member
I have no strong feeling on that one, the place you picked is probably fine too :) |
CoffeeFlux
force-pushed
the
cattr-interfaces
branch
from
3e92efa to
f625489
Compare
akoeplinger
approved these changes
Mar 24, 2020
Looking at dotnet#7190, the .NET Core behavior here is strange and my changes in dotnet@0844cb7a6152 with the type checking may have been a mistake. I think this should be fine with the interface special-casing, but if deemed too great a concern I can revert that subset of my old changes. Additionally, if people come up with other scenarios where this might fail, I'll just revert until we can migrate to use a shared CustomAttribute implementation rather than try to play whack-a-mole.
CoffeeFlux
force-pushed
the
cattr-interfaces
branch
from
f625489 to
6d224ce
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33639
Looking at #7190, the .NET Core behavior here is strange and my changes in 0844cb7a6152 with the type checking may have been a mistake. I think this should be fine with the interface special-casing, but if deemed too great a concern I can revert that subset of my old changes. Additionally, if people come up with other scenarios where this might fail, I'll just revert until we can migrate to use a shared CustomAttribute implementation rather than try to play whack-a-mole.