Import Microsoft.Managed targets in Sdk.IL #34124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Microsoft.Managed targets aren't imported, multitargeting is broken as the required `InnerBuildProperty` and `InnerBuildPropertyValues` properties aren't defined. Those properties are read by the Graph APIs to identify if a build is an outer or inner build and multiplexes on them. Fixes #34123
akoeplinger
approved these changes
Mar 26, 2020
Member
Author
|
Merging as this change isn't exercised in CI and to be able to consume the package in the blocked PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Microsoft.Managed targets aren't imported, multitargeting is broken as the required
InnerBuildPropertyandInnerBuildPropertyValuesproperties aren't defined. Those properties are read by the Graph APIs to identify if a build is an outer or inner build and multiplexes on them.This mimics what the CSharp target does: https://github.com/microsoft/msbuild/blob/2d82e1a861d890fce68c8e2d42b569e5bbaf5687/src/Tasks/Microsoft.CSharp.targets#L159-L163
Fixes #34123
Unblocks #33553
🗡 This took me 4h to root cause 🗡