Fix undetermined SPMI behavior. #34183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreenko
added
the
area-CodeGen-coreclr
BruceForstall
approved these changes
Mar 27, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observed behavior was very funny: I was getting hundreds of diffs with the same -b and -d jit, but when I turned JitDump on they were all disappearing, took me a while to catch the issue.
The new field was added in #32270, @fadimounir please notify jit-contrib if you add or delete fields from
struct CORINFO_*, because we need to mirror that in SPMI.It will require a new SPMI collection (the old will fail with buffer overread).