WASM: Enable System.Runtime.Serialization.Formatters tests #38948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to preserve some assemblies the BinaryFormatter needs and also skip some test cases that would cause PNSE on WebAssembly.
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
99 tasks
stephentoub
reviewed
Jul 8, 2020
| SqlError sqlError = null; | ||
| // .NET Framework has no constructor overload for passing an exception | ||
| if (PlatformDetection.IsNetFramework) | ||
| if (!PlatformDetection.IsBrowser) // System.Data.SqlClient doesn't work on Browser |
Member
Member
There was a problem hiding this comment.
I'm fine with removing them given they would effectively not be catching anything any longer.
stephentoub
approved these changes
Jul 8, 2020
safern
reviewed
Jul 8, 2020
safern
reviewed
Jul 8, 2020
safern
approved these changes
Jul 8, 2020
This was referenced Jul 9, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to preserve some assemblies the BinaryFormatter needs and also skip some test cases that would cause PNSE on WebAssembly:
Tests run: 6384, Errors: 0, Failures: 0, Skipped: 0. Time: 58.90189s