use port in SPN calculation if not default #40860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
SteveSyfuhs
approved these changes
Aug 14, 2020
geoffkizer
reviewed
Aug 15, 2020
| hostName = result.HostName; | ||
| } | ||
|
|
||
| if (!isProxyAuth && !authUri.IsDefaultPort) |
Contributor
There was a problem hiding this comment.
Why not for proxy auth?
If it's just to minimize change, then we should add a comment about this. Actually we should probably add a comment regardless.
Member
Author
There was a problem hiding this comment.
yes, it was minimize the change. I was not sure but since nobody complained about proxies, I left it as it was.
I'm also not sure if the the proxy default port would match web server port.
Contributor
There was a problem hiding this comment.
Ok. Can we add a comment?
Member
Author
|
all tests passing now. |
scalablecory
approved these changes
Aug 17, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we should use port in SPN if not default. At least that what framework did.
I added code to do that if
Hostheader is not present. If it is, we would still prefer it and that should allow some customization until we have API to set SPN explicitly (or have mapper like Framework did)Long term, we may add some code to probe if given SPN exist and possibly fallback to alternatives when it does not.
As far as the test, I added new instance of the same container. When I had simply to services on the same machine, test code worked even if we did not use the port.
As the configuration got more complicated, patching config via sed is more tricky. So instead, I submitted what is outcome of old code and I modified that directly. There could be more cleanup and I want to add NTLM as well but for now I keep it only with necessary changes.
fixes #36644
cc: @SteveSyfuhs