Mark some System.Collection APIs as unsupported on Browser WASM

[MaximLipnin]

The following methods from System.Collections.* namespaces were listed by the platform compatibility analyzer (https://github.com/dotnet/platform-compat) as throwing PNSE on Browser WASM so they can be marked as unsupported using
UnsupportedOSPlatformAttribute("browser") attribute:

DocID	Namespace	Type	Member	Nesting
M:System.Collections.Generic.LinkedList`1.Enumerator.System#Runtime#Serialization#ISerializable#GetObjectData(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)	System.Collections.Generic	LinkedList+Enumerator	System.Runtime.Serialization.ISerializable.GetObjectData(SerializationInfo, StreamingContext)	0
M:System.Collections.Generic.LinkedList`1.Enumerator.System#Runtime#Serialization#IDeserializationCallback#OnDeserialization(System.Object)	System.Collections.Generic	LinkedList+Enumerator	System.Runtime.Serialization.IDeserializationCallback.OnDeserialization(Object)	0
M:System.Collections.Generic.SortedSet`1.Enumerator.System#Runtime#Serialization#ISerializable#GetObjectData(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)	System.Collections.Generic	SortedSet+Enumerator	System.Runtime.Serialization.ISerializable.GetObjectData(SerializationInfo, StreamingContext)	0
M:System.Collections.Generic.SortedSet`1.Enumerator.System#Runtime#Serialization#IDeserializationCallback#OnDeserialization(System.Object)	System.Collections.Generic	SortedSet+Enumerator	System.Runtime.Serialization.IDeserializationCallback.OnDeserialization(Object)	0
M:System.Collections.Specialized.NameObjectCollectionBase.#ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)	System.Collections.Specialized	NameObjectCollectionBase	.ctor(SerializationInfo, StreamingContext)	0
M:System.Collections.Specialized.NameObjectCollectionBase.OnDeserialization(System.Object)	System.Collections.Specialized	NameObjectCollectionBase	OnDeserialization(Object)	0
M:System.Collections.Specialized.NameObjectCollectionBase.GetObjectData(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)	System.Collections.Specialized	NameObjectCollectionBase	GetObjectData(SerializationInfo, StreamingContext)	0
M:System.Collections.Specialized.NameValueCollection.#ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)	System.Collections.Specialized	NameValueCollection	.ctor(SerializationInfo, StreamingContext)	1

Part of #41087

[ghost]

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

[jkotas]

This throws everywhere. Why mark it as unsupported for browser only?

[MaximLipnin]

That's good question, thanks. I'm not sure if there is something like [UnsupportedOSPlatform("all")] to mark it for all the possible platforms. So in this case I've done it only for the related part.

[safern]

cc: @jeffhandley @adamsitnik did we consider an "all" value for the analyzer?

[jeffhandley]

Would [Obsolete] be more appropriate for something not supported anywhere?

This makes me feel uneasy saying it, but I think you could pull off "not supported anywhere" by using [SupportedOSPlatform("none")]; I don't think I would endorse it though.

[jkotas]

I would start with some better examples than this one.

The binary serialization methods touched in this PR are on interfaces and/or not meant to be directly called by user code. It means that the annotations on them are not going to make any difference in user experience. I think that the right action for these specific methods may be to do nothing and leave them alone.

[safern]

Yeah I agree these ones we should not annotate them at all. I was just wondering if we should support an annotation for "ALL" platforms.

[jeffhandley]

I was just wondering if we should support an annotation for "ALL" platforms.

I'll follow up on that off this issue

[jkotas]

I am not sure whether it makes sense to start marking the binary serialization support methods as unsupported. @GrabYourPitchforks Do you have thoughts on this?

The binary serialization support methods are not meant to be directly called by user code, so marking them as unsupported via attributes does not provide much value.

[MaximLipnin]

I am not sure whether it makes sense to start marking the binary serialization support methods as unsupported. @GrabYourPitchforks Do you have thoughts on this?

The binary serialization support methods are not meant to be directly called by user code, so marking them as unsupported via attributes does not provide much value.

Thanks for clarification. There are over 4500 members that throw PNSE on Browser WASM at the moment. I picked up some small portion consisting of only System.Collection-related items for this PR. If those are not supposed to be marked then I could proceed with other namespaces.

[MaximLipnin]

Based on the feedback, I'm closing this PR for now.

[GrabYourPitchforks]

@jkotas I agree it doesn't add much value to annotate serialization-related infrastructure. If the annotations are added by hand I'd not burn cycles adding them.