Skip to content

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 24, 2020

Contributes to #41087

All the public APIs are to be marked as unsupported, so it is marked at the assembly level.

M:System.Diagnostics.FileVersionInfo.get_IsSpecialBuild,System.Diagnostics,FileVersionInfo,get_IsSpecialBuild(),0
M:System.Diagnostics.FileVersionInfo.get_FileName,System.Diagnostics,FileVersionInfo,get_FileName(),0
M:System.Diagnostics.FileVersionInfo.get_FileDescription,System.Diagnostics,FileVersionInfo,get_FileDescription(),0
M:System.Diagnostics.FileVersionInfo.get_OriginalFilename,System.Diagnostics,FileVersionInfo,get_OriginalFilename(),0
M:System.Diagnostics.FileVersionInfo.get_Language,System.Diagnostics,FileVersionInfo,get_Language(),0
M:System.Diagnostics.FileVersionInfo.get_LegalTrademarks,System.Diagnostics,FileVersionInfo,get_LegalTrademarks(),0
M:System.Diagnostics.FileVersionInfo.get_SpecialBuild,System.Diagnostics,FileVersionInfo,get_SpecialBuild(),0
M:System.Diagnostics.FileVersionInfo.get_ProductBuildPart,System.Diagnostics,FileVersionInfo,get_ProductBuildPart(),0
M:System.Diagnostics.FileVersionInfo.get_FileVersion,System.Diagnostics,FileVersionInfo,get_FileVersion(),0
M:System.Diagnostics.FileVersionInfo.get_ProductPrivatePart,System.Diagnostics,FileVersionInfo,get_ProductPrivatePart(),0
M:System.Diagnostics.FileVersionInfo.get_PrivateBuild,System.Diagnostics,FileVersionInfo,get_PrivateBuild(),0
M:System.Diagnostics.FileVersionInfo.get_FilePrivatePart,System.Diagnostics,FileVersionInfo,get_FilePrivatePart(),0
M:System.Diagnostics.FileVersionInfo.get_LegalCopyright,System.Diagnostics,FileVersionInfo,get_LegalCopyright(),0
M:System.Diagnostics.FileVersionInfo.get_FileBuildPart,System.Diagnostics,FileVersionInfo,get_FileBuildPart(),0
M:System.Diagnostics.FileVersionInfo.ToString,System.Diagnostics,FileVersionInfo,ToString(),0
M:System.Diagnostics.FileVersionInfo.get_IsDebug,System.Diagnostics,FileVersionInfo,get_IsDebug(),0
M:System.Diagnostics.FileVersionInfo.GetVersionInfo(System.String),System.Diagnostics,FileVersionInfo,GetVersionInfo(String),0
M:System.Diagnostics.FileVersionInfo.get_ProductMajorPart,System.Diagnostics,FileVersionInfo,get_ProductMajorPart(),0
M:System.Diagnostics.FileVersionInfo.get_ProductName,System.Diagnostics,FileVersionInfo,get_ProductName(),0
M:System.Diagnostics.FileVersionInfo.get_InternalName,System.Diagnostics,FileVersionInfo,get_InternalName(),0
M:System.Diagnostics.FileVersionInfo.get_FileMinorPart,System.Diagnostics,FileVersionInfo,get_FileMinorPart(),0
M:System.Diagnostics.FileVersionInfo.get_IsPrivateBuild,System.Diagnostics,FileVersionInfo,get_IsPrivateBuild(),0
M:System.Diagnostics.FileVersionInfo.get_FileMajorPart,System.Diagnostics,FileVersionInfo,get_FileMajorPart(),0
M:System.Diagnostics.FileVersionInfo.get_ProductVersion,System.Diagnostics,FileVersionInfo,get_ProductVersion(),0
M:System.Diagnostics.FileVersionInfo.get_Comments,System.Diagnostics,FileVersionInfo,get_Comments(),0
M:System.Diagnostics.FileVersionInfo.get_IsPatched,System.Diagnostics,FileVersionInfo,get_IsPatched(),0
M:System.Diagnostics.FileVersionInfo.get_CompanyName,System.Diagnostics,FileVersionInfo,get_CompanyName(),0
M:System.Diagnostics.FileVersionInfo.get_ProductMinorPart,System.Diagnostics,FileVersionInfo,get_ProductMinorPart(),0
M:System.Diagnostics.FileVersionInfo.get_IsPreRelease,System.Diagnostics,FileVersionInfo,get_IsPreRelease(),0

@ghost
Copy link

ghost commented Aug 24, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@mdh1418 mdh1418 merged commit c72d522 into dotnet:master Aug 25, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_diagnositcs_fileversioninfo_unsupported branch August 25, 2020 13:40
mdh1418 added a commit to mdh1418/runtime that referenced this pull request Sep 8, 2020
mdh1418 added a commit that referenced this pull request Sep 9, 2020
* [wasm] Mark System.ComponentModel APIs as unsupported on Browser (#41094)

* [wasm] System.ComponentModel enable platform attributes

* [wasm] Mark ExtendedProtectionPolicyTypeConverter.ConvertTo as unsupported

* [wasm] Mark System.ComponentModel.TypeDescriptor.CreateInstance as unsupported

* [wasm] Mark System.ComponentModel.TypeDescriptionProvider.CreateInstance as unsupported

* [wasm] Mark System.ComponentModel.LicenseManager.CreateWithContext as unsupported

* [wasm] Mark System.ComponentModel.MaskedTextProvider.Clone as unsupported

Co-authored-by: Mitchell Hwang <[email protected]>

* [wasm] Mark System.Console APIs as unsupported on Browser (#41184)

* [wasm] Mark System.Console APIs as unsupported on Browser

* System.Console remove unsupported attribute from Console.Clear()

* System.Console mark SetIn as unsupported on Browser

* System.Console move UnsupportedOSPlatform attributes down to the accessor

Co-authored-by: Mitchell Hwang <[email protected]>

* Mark System.Diagnostics.FileVersionInfo as unsupported on Browser (#41271)

Co-authored-by: Mitchell Hwang <[email protected]>

* Mark System.Diagnostics.Process unsupported at assembly level (#41694)

Co-authored-by: Mitchell Hwang <[email protected]>

* [wasm] Mark System.IO.Compression APIs as unsupported on Browser (#41683)

* [wasm] System.IO.Compression.Brotli enable platform attributes

* Mark System.IO.Compression.Brotli unsupported at assembly level

Co-authored-by: Mitchell Hwang <[email protected]>

* [wasm] Mark System.IO.FileSystem.Watcher APIs as unsupported on Browser (#41682)

* [wasm] System.IO.FileSystem.Watcher enable platform attributes

* Mark System.IO.FileSystem.Watcher unsupported at assembly level

Co-authored-by: Mitchell Hwang <[email protected]>

* [wasm] Mark System.IO.IsolatedStorage APIs as unsupported on Browser (#41700)

* [wasm] System.IO.IsolatedStorage enable platform attributes

* Mark System.IO.IsolatedStorage Unsupported at assembly level

Co-authored-by: Mitchell Hwang <[email protected]>

* Mark some System.Net.* APIs as unsupported on Browser WASM (#40924)

* [wasm] Mark System.Threading.ThreadPool unsupported on Browser (#41891)

* System.Threading.ThreadPool enable platform attributes

* Mark System.Threading.ThreadPool APIs unsupported on browser

* System.Threading.ThreadPool Add Unsupported attribute to other ThreadPool files

* Remove Unsupported attributes from BindHandle

* Add windows Supported Attribute to BindHandle

Co-authored-by: Mitchell Hwang <[email protected]>

* Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser (#41963)

* Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser

* Add the attributes to non-browser version of ClientWebSocketOptions class to avoid build error

* Add using

* Include platform attributes

* [wasm] Mark System.Net.NameResolution Unsupported at assembly level (#41985)

Co-authored-by: Mitchell Hwang <[email protected]>

Co-authored-by: Mitchell Hwang <[email protected]>
Co-authored-by: Maxim Lipnin <[email protected]>
mdh1418 added a commit to mdh1418/runtime that referenced this pull request Sep 11, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants