[release/5.0] [wasm][net] System.Net.Mail should not throw PNSE for full assembly. #43213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SmtpClient relevant tests are not supported
…operties - It does not hurt to have this.
|
Tagging subscribers to this area: @dotnet/ncl |
leecow
added
Servicing-approved
marek-safar
approved these changes
Oct 13, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42974 to release/5.0
It fixes customer reports of a regression from 3.2 where Browser lost support for mail operations as outlined in issue: #42576
/cc @kjpou1
Customer Impact
System.Net.Mail assembly is used by customers to verify mail addresses.
ContentDisposition is used and exposed in Http headers. Client relied on this functionality to be there for their existing code base to work after migration to 5.0.
SmtpClient is not supported via browser environment and is marked as PNSE.
Testing
Unit and Functional tests are included except for those concerning SmtpClient which is not delivered and marked as PNSE.
Risk
Would be calculation as low as it adds back support for functionality that was delivered before. SmtpClient is marked as PNSE and not delivered as it is not supported on browser environments and thus be calculated as zero functionality risk.