Skip to content

[release/5.0] Modify System.Net.HttpListener to throw PNSE at assembly level on browser #43523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2020
Merged

[release/5.0] Modify System.Net.HttpListener to throw PNSE at assembly level on browser #43523

merged 2 commits into from
Oct 20, 2020

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 16, 2020 •
edited by akoeplinger
Loading

Backport of #43401 to release/5.0

/cc @akoeplinger @MaximLipnin

Customer Impact

No warnings from the PlatformNotSupported analyzer when a customer tries to use HttpListener on browser-wasm which isn't supported there.

Testing

Tested on CI.

Risk

Low, just changes/adds UnsupportedOSPlatform attributes.

@ghost
Copy link

ghost commented Oct 16, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@runfoapp runfoapp bot mentioned this pull request Oct 16, 2020
Open
@lewing lewing added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 16, 2020
lewing
lewing approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in tactics email

@lewing
Copy link
Member

lewing commented Oct 20, 2020

build 20201016.60 --

Browser failure is caused by space limitations and fixed by #43598

Windows failure is #42677

@lewing lewing merged commit 46c9477 into release/5.0 Oct 20, 2020
@lewing lewing deleted the backport/pr-43401-to-release/5.0 branch October 20, 2020 01:20
@mmitche mmitche added this to the 5.0.1 milestone Nov 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-System.Net Servicing-approved Approved for servicing release

Projects

None yet

Milestone

5.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@lewing @mmitche @Dotnet-GitSync-Bot @MaximLipnin