Skip to content

Avoid unnecessary LINQ and string joins in JsonConfigurationFileParser #44734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

Avoid unnecessary LINQ and string joins in JsonConfigurationFileParser #44734

merged 1 commit into from
Nov 17, 2020
+18 −22

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Nov 16, 2020 •
edited
Loading

Some unnecessary work in a dotnet new mvc app's startup:
image

Related to #44598

@stephentoub stephentoub added this to the 6.0.0 milestone Nov 16, 2020
@ghost
Copy link

ghost commented Nov 16, 2020

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
Description:

Some unnecessary work in dotnet new mvc startup:
image
Author: stephentoub
Assignees: -
Labels:

area-Extensions-Configuration, tenet-performance
Milestone: [object Object]

maryamariyan
maryamariyan approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@maryamariyan maryamariyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@runfoapp runfoapp bot mentioned this pull request Nov 16, 2020
Closed
jkotas
jkotas approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@runfoapp runfoapp bot mentioned this pull request Nov 17, 2020
Closed
@stephentoub stephentoub merged commit 86580a3 into dotnet:master Nov 17, 2020
@stephentoub stephentoub deleted the jsonlinq branch November 17, 2020 16:37
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

+2 more reviewers

@benaadams benaadams benaadams left review comments

@maryamariyan maryamariyan maryamariyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-Configuration tenet-performance Performance related issue

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub @benaadams @maryamariyan @jkotas