Skip to content

FileSystem.AccessControl tests not cleaning files properly #47074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 9, 2021
Merged

FileSystem.AccessControl tests not cleaning files properly #47074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1bffac4
FileSystem.AccessControl tests not cleaning files properly
carlossanlop Jan 16, 2021
f527694
Temp commit to verify files and dirs deleted without try catch
carlossanlop Jan 26, 2021
5dfd51f
Set directory security first, then file security, in DeleteDirectory.…
carlossanlop Jan 26, 2021
cb4bec4
Restore try catch before merging.
carlossanlop Jan 27, 2021
df559c0
Address suggestions.
carlossanlop Feb 2, 2021
ba6bf54
Bring back tests that consume the parameterless security constructors…
carlossanlop Feb 3, 2021
d1e9896
NotFound test
carlossanlop Feb 4, 2021
4f8d3e2
FileShare.None
carlossanlop Feb 4, 2021
75230bf
InlineData FileMode
carlossanlop Feb 4, 2021
8f4e43e
Rename method that creates per platform. Bring back inline data.
carlossanlop Feb 4, 2021
13c457c
Address suggestions
carlossanlop Feb 4, 2021
e702f05
Address suggestions
carlossanlop Feb 4, 2021
b716dff
Address suggestions
carlossanlop Feb 4, 2021
283d478
Reverting Verify_FileSecurity_CreateFile to the original arguments
carlossanlop Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/Common/tests/System/IO/TempDirectory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace System.IO
/// Represents a temporary directory. Creating an instance creates a directory at the specified path,
/// and disposing the instance deletes the directory.
/// </summary>
public sealed class TempDirectory : IDisposable
public class TempDirectory : IDisposable
{
public const int MaxNameLength = 255;

Expand Down Expand Up @@ -40,7 +40,7 @@ public void Dispose()

public string GenerateRandomFilePath() => IO.Path.Combine(Path, IO.Path.GetRandomFileName());

private void DeleteDirectory()
protected virtual void DeleteDirectory()
{
try { Directory.Delete(Path, recursive: true); }
catch { /* Ignore exceptions on disposal paths */ }
Expand Down
Loading