mono: remove ENABLE_NETCORE and associated framework code #47925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoffeeFlux
requested review from
BrzVlad,
DavidKarlas,
EgorBo,
SamMonoRT,
imhameed,
lateralusX,
marek-safar,
naricc and
thaystg
as code owners
ghost
added
the
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsHopefully this still builds? Not sure if we want to take it right now, but it's a lot of code to get rid of so I'm personally in favor.
|
CoffeeFlux
force-pushed
the
sayonara-framework
branch
from
13b0456 to
8c3082c
Compare
Contributor
Author
|
Should build now, oops. |
akoeplinger
reviewed
Feb 5, 2021
I don't see anything calling this
lambdageek
reviewed
Feb 5, 2021
Comment on lines
4333
to
4334
| // TODO: make this work on netcore when working on SRE.TypeBuilder | ||
| g_assert_not_reached (); |
akoeplinger
approved these changes
Feb 5, 2021
lambdageek
approved these changes
Feb 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this still builds? Not sure if we want to take it right now, but it's a lot of code to get rid of so I'm personally in favor.