Skip to content

Fix JIT rolling build #48552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2021
Merged

Fix JIT rolling build #48552

merged 1 commit into from
Feb 20, 2021

Conversation

@am11
Copy link
Member

@am11 am11 commented Feb 20, 2021

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 20, 2021
am11
am11 commented Feb 20, 2021
View reviewed changes
src/coreclr/clrdefinitions.cmake Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused since 2ffb39e (this is the only occurrence).

@am11 am11 mentioned this pull request Feb 20, 2021
Merged
VSadov
VSadov approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@VSadov VSadov merged commit 4d310fb into dotnet:master Feb 20, 2021
@BruceForstall
Copy link
Contributor

Thanks for the quick fix.

@am11 am11 deleted the feature/jit/rolling-build-fixes branch February 20, 2021 23:51
@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Feb 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@VSadov VSadov VSadov approved these changes

Assignees

@am11 am11

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@am11 @BruceForstall @VSadov @JulieLeeMSFT