Apple Silicon disable failing PAL tests #48782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangod9
approved these changes
Feb 25, 2021
sdmaclea
added a commit
to sdmaclea/runtime
that referenced
this pull request
Feb 26, 2021
This reverts commit 03d414b.
I wasn't aware of any, but after it merged, I found the PAL |
sdmaclea
added a commit
that referenced
this pull request
Mar 2, 2021
* Setup OSX.1100.ARM64.* helix queues * Enable Apple Silicon test on initial set of several CI pipelines (no-PR). * Disable failing Apple Silicon PAL tests * Revert "Apple Silicon disable failing PAL tests (#48782)"
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable PAL tests failing on Apple Silicon in CI.
Some of these may/will need to be investigated and fixed. I'll open an issue (See #48783).
This is following the pattern of how PAL tests are disabled. For instance
runtime/src/coreclr/pal/tests/palsuite/threading/GetCurrentThread/test1/thread.cpp
Lines 33 to 38 in 6a80a38
@mangod9 This is needed for clean CI. Can you review or delegate review in @janvorli absence