Remove some allocations related to logging configuration #50055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidfowl
commented
Mar 22, 2021
davidfowl
commented
- Today we allocate enumerators when enumerating custom attributes, this changes a for loop into a foreach and removes the inner foreach loop.
- Today we allocate enumerators when enumerating custom attributes, this changes a for loop into a foreach and removes the inner foreach loop.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @maryamariyan Issue Details
|
Member
|
If happy for it to throw if more that one defined; assuming I can resolve the merge conflicts... This would reduce it to a single allocation for the attribute? #45121 |
benaadams
approved these changes
Mar 22, 2021
stephentoub
reviewed
Mar 22, 2021
src/libraries/Common/src/Extensions/ProviderAliasUtilities/ProviderAliasUtilities.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 22, 2021
davidfowl
commented
Mar 22, 2021
maryamariyan
approved these changes
Mar 22, 2021
|
Hello @maryamariyan! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
src/libraries/Microsoft.Extensions.Logging/src/LoggerFilterOptions.cs
Outdated
Show resolved
Hide resolved
…ions.cs Co-authored-by: Jonas Nyrup <[email protected]>
stephentoub
approved these changes
Mar 23, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.