Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 25, 2021

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20210327.1
  • Date Produced: 3/27/2021 8:55 AM
  • Commit: 318105ce4619c651d26caeed4cb32c63eefdf3ee
  • Branch: refs/heads/main

Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21174.1
@ghost
Copy link

ghost commented Mar 25, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-maestro bot and others added 4 commits March 27, 2021 09:03
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21176.1
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21177.1
@dotnet-maestro dotnet-maestro bot requested a review from marek-safar as a code owner March 28, 2021 09:39
@stephentoub stephentoub requested a review from eerhardt March 29, 2021 03:04
</type>

<type fullname="System.ValueType">
<!-- https://github.com/dotnet/runtime/issues/47909 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this issue is attached to this entry. The issue says

Remove DynamicDependency from ValueType in browser builds

But this entry is unconditionally preserving the constructor on ValueType, which are two different things in my mind.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove it from the xml if you want. It's only a reminder to remove it once we land final solution for System.Runtime.InteropServices.JavaScript.Runtime dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we need ValueType.ctor() in the xml?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some tiny sample which managed to not require ValueType hence dropping the required dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to remove this comment, since it isn't relevant to what is being done here in the xml. I can do that in a follow up PR, so we can merge this to unblock the integration.

@eerhardt eerhardt merged commit 860518b into main Mar 29, 2021
@eerhardt eerhardt deleted the darc-main-c166b29d-6e6b-441c-9f48-b7b243d18ecb branch March 29, 2021 17:15
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants