[release/6.0-preview3] [mbr] Fix encmap boundary and method RVA lookup. #50254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two separate issues: 1. When we process the EnC map, any tables after the last one that has an update gets an "enc_recs" pointer that's one past the last row of the table. (the enc_recs pointer is used to speed up relative address lookup). So at lookup time if enc_recs says to look past the end of the EnC map table, we know there won't be any updates - return -1. 2. When looking for the updated RVA of a method, we need to go through every delta and find the latest one that has an update for the given method. The problem is that if a later generation doesn't have an update, we would take the NULL return value at face value and it would look like the method had no updates to its body - we would go back to using the original version from before any updates were applied. Instead now ignore lookup table misses and remember the last successful lookup. Fixes dotnet#50190
This was referenced Mar 25, 2021
CoffeeFlux
approved these changes
Mar 25, 2021
marek-safar
added
Servicing-approved
|
@marek-safar Is this ready for merge? |
Yes |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #50248 to release/6.0-preview3 (backported by hand)
Customer Impact
Avoids unexpected hot reload behavior in BlazorWasm projects. Note dotnet/aspnetcore#31216 - the customers won't get hot reload by default in Preview 3, they will have to explicitly opt in.
Testing
Tested locally.
Risk
Minimal, hot reload isn't on by default.
Fixes #50190