Closing opened handles to avoid resource leak. #51950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SymReader::InitializeFromFile opens file handles which were not closed causing resource leaks on each call. Fix dotnet#50422
ghost
added
the
|
Tagging subscribers to this area: @tommcdon Issue DetailsSymReader::InitializeFromFile opens file handles which were not closed causing resource leaks on each call. Fix #50422
|
Member
|
@mikem8361 PTAL |
mikem8361
approved these changes
May 21, 2021
Contributor
Author
|
Is there anything left to do for me after this pull request is approved? Or just waiting for someone with write access to merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymReader::InitializeFromFile opens file handles which were not closed causing resource leaks on each call.
Fix #50422